Fix: Improve documentation for Built-in Blog doc #2708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dedelweiss
changed the title
Dedelweiss
force-pushed
the
improve_doc_build_blog
branch
from
2b0ec51 to
8056019
Compare
ckipp01
requested changes
Mar 2, 2023
There was a problem hiding this comment.
Thanks for the pr @Dedelweiss. Here's some initial feedback.
Dedelweiss
force-pushed
the
improve_doc_build_blog
branch
from
cfabc99 to
e2d9714
Compare
Corrections of some nits Correction of nits Corrections text correction
Dedelweiss
force-pushed
the
improve_doc_build_blog
branch
from
697ef8f to
6e89d61
Compare
Dedelweiss
changed the title
ckipp01
requested changes
Mar 10, 2023
There was a problem hiding this comment.
Sorry for the delay in reviewing this @Dedelweiss. Just one more point.
ckipp01
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
I think this is a nice small change. Thanks @Dedelweiss. I'll wait for another ✅ and then we can get this merged.
julienrf
reviewed
Mar 13, 2023
julienrf
reviewed
Mar 13, 2023
SethTisue
reviewed
Mar 13, 2023
Dedelweiss
requested review from
SethTisue,
julienrf and
ckipp01
and removed request for
SethTisue,
julienrf and
ckipp01
Dedelweiss
requested review from
SethTisue and
julienrf
and removed request for
SethTisue and
julienrf
julienrf
reviewed
Mar 14, 2023
julienrf
reviewed
Mar 14, 2023
Dedelweiss
force-pushed
the
improve_doc_build_blog
branch
2 times, most recently
from
d1d60da to
6867cba
Compare
SethTisue
reviewed
Mar 14, 2023
Dedelweiss
force-pushed
the
improve_doc_build_blog
branch
from
6867cba to
bfe6b4a
Compare
|
Thank you very much for your feedback! I am correcting all of this, these are parts I put in that I thought would be interesting for beginners, but if there are parts I should add or correct, I am all for it! |
julienrf
approved these changes
Mar 14, 2023
Dedelweiss
force-pushed
the
improve_doc_build_blog
branch
from
bfe6b4a to
5a671d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First proposal to improve the "Built-in blog" page
Add parts :
Result